138 refactored #153
Open
138 refactored #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKMaily
reviewed
May 2, 2024
| {Key::WvForms_warning, "Warnung!"}, | ||
| {Key::Devices_found, "Geräte"}, | ||
| {Key::Usr_curnt_wave, "Aktuelle Wellenform Des Benutzers"}, | ||
| {Key::Wv_from_file, "Wellenform Aus Datei"}, |
src/languages.hpp
Outdated
| {Key::y_axis_label, "y [Volt]"}, | ||
| {Key::Record_Data, "Datenaufnahme"}, | ||
| {Key::Ready, "Ready"}, | ||
| {Key::German, "Bereit"}}; |
There was a problem hiding this comment.
{Key::Ready, "Ready"} should be {Key::Ready, "Bereit"} as well, I guess. They were correct already, not sure why you changed them.
R-Abbasi
reviewed
May 3, 2024
| @@ -117,7 +121,8 @@ inline const std::map<Key, const char *> englishLan{ | |||
| {Key::Stop, "Stop"}, | |||
| {Key::Continue, "Continue"}, | |||
| {Key::Continue_del, "Continue Deletion?"}, | |||
| {Key::Devices_found, "Devices found:"}, | |||
There was a problem hiding this comment.
There's a colon at the end to indicate a list.
src/languages.hpp
Outdated
| @@ -117,7 +121,8 @@ inline const std::map<Key, const char *> englishLan{ | |||
| {Key::Stop, "Stop"}, | |||
| {Key::Continue, "Continue"}, | |||
| {Key::Continue_del, "Continue Deletion?"}, | |||
| {Key::Devices_found, "Devices found:"}, | |||
| {Key::Devices_found, "Devices found"}, | |||
| {Key::Device_List, "Devicelist"}, | |||
There was a problem hiding this comment.
{Key::Device_List, "Devices list"} not better, please?
AKMaily
requested changes
May 6, 2024
R-Abbasi
reviewed
May 29, 2024
| @@ -236,8 +236,7 @@ inline const std::map<Key, const char *> germanLan{ | |||
| {Key::x_axis_label, "x [Sekunden]"}, | |||
| {Key::y_axis_label, "y [Volt]"}, | |||
| {Key::Record_Data, "Datenaufnahme"}, | |||
| {Key::Ready, "Ready"}, | |||
| {Key::German, "Bereit"}}; | |||
| {Key::Ready, "bereit"}}; | |||
There was a problem hiding this comment.
All messages in both English and German languages start with a capital letter, hence "Bereit" seems more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes in language Linking.